chore(ci): add security.yml version marker + document >5-repos switchover#21
Merged
Merged
Conversation
…over The security workflow is copy-and-propagated across repos today; without a version marker at the top of the file there is no key for a future drift check to bind to. Add the marker per Lead Go review on PR #5, and document the >5-repos threshold for switching to a workflow_call reusable workflow in CONTRIBUTING.md so the next person who edits the workflow knows the rule. No behavior change to the workflow itself. Withings-export-cli carries the same marker in a parallel PR. Refs QUA-47. Co-Authored-By: Paperclip <noreply@paperclip.ing>
DTTerastar
approved these changes
May 19, 2026
2 tasks
DTTerastar
pushed a commit
to quantcli/withings-export-cli
that referenced
this pull request
May 19, 2026
Mirrors quantcli/common#21. The security workflow is copy-and-propagated across repos today; a version marker at the top of the file gives a future drift-check job a stable key to bind to. No behavior change. Per Lead Go review on quantcli/common#5: quantcli/common#5 (review) Refs QUA-47. Co-authored-by: QualitySecurity <qualitysecurity@quantcli.local> Co-authored-by: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from Lead Go Engineer review on PR #5. Two small, behavior-neutral additions so the next person who edits the workflow knows the rules.
# security.yml v1 — source of truth: quantcli/common; sync changes to every *-export-cli.) at the top of.github/workflows/security.yml. A future drift-check job will key off this marker.>5 repos → workflow_callswitchover trigger inCONTRIBUTING.mdunder "Supply-chain and security", with the rationale (drift mitigation vs. centralization cost) and the original review link for context.No behavior change to the workflow itself. The same marker is being added to
withings-export-cli/.github/workflows/security.ymlin a parallel PR;liftoff-export-cliandcrono-export-clipick it up when they onboard the workflow.What changed
.github/workflows/security.yml: 4-line marker prepended abovename:(kept the existing 3-line block intact — those are propagation hints, the marker is the version key).CONTRIBUTING.md: new "Where the workflow lives, and when to centralize it" subsection under "Supply-chain and security".Why
common's copy.CONTRIBUTING.mdmakes the trigger explicit.Implications for per-service CLIs
withings-export-cligets the same marker (its security.yml is byte-identical today).liftoff-export-cliandcrono-export-climust include the marker on day one. The CONTRIBUTING.md note codifies this.Test plan
security.ymland the new subsection renders cleanly inCONTRIBUTING.md.Refs QUA-47.
🤖 Generated with Claude Code